"So if you sinful people know how to give good gifts to your children, how much more will your heavenly Father give the Holy Spirit to those who ask him." Luke 11:13
We always wonder why great Christians we know suffer, when God has promised that He withholds no good thing from us. The most Godly woman I have ever known is now trying to raise her kids without their dad who's found someone else. Another friend is pursuing God daily but has no transportation, can barely walk and now needs to be monitored daily for the condition of her congestive heart failure.
As Sara Groves tells us on her latest commentary record, the only thing we can conclude is that the things that we think of as good things are not the same "good things" that God is thinking of. Her song summarizes it so well. Pain, thirst and lack are no measure of His faithfulness. The greatest gift He gives us is Himself through the Holy Spirit.